Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[util] Add new "Zusi 3" exe filename #3315

Merged
merged 1 commit into from
Apr 13, 2023
Merged

[util] Add new "Zusi 3" exe filename #3315

merged 1 commit into from
Apr 13, 2023

Conversation

w-flo
Copy link
Contributor

@w-flo w-flo commented Mar 27, 2023

Hopefully the regex is correct. It works for ZusiSim.64.exe (which is the executable launched by steam), but I'm not sure how to launch the legacy 32 bit "ZusiSim.exe" in steam, so I have not tested if that still works correctly.

Commit message:

In addition to the legacy "ZusiSim.exe" executable, the recent 3.5 release added a 64-bit "ZusiSim.64.exe" executable. This is now the default executable when launching the game in Steam. The game is unplayable without this option, so update the regex for Zusi 3.

Fixes #3250.

In addition to the legacy "ZusiSim.exe" executable, the recent 3.5
release added a 64-bit "ZusiSim.64.exe" executable. This is now the
default executable when launching the game in Steam. The game is
unplayable without this option, so update the regex for Zusi 3.

Fixes doitsujin#3250.
@w-flo
Copy link
Contributor Author

w-flo commented Mar 28, 2023

Updated commit message to add "Fixes #3250.".

Also, I have now verified that the regex still works for the 32-bit exe filename "ZusiSim.exe" after updating 32 bit dxvk dlls in the compatdata wine prefix (launching it from the command line using Proton's wine executable and the compatdata wine prefix simply works as expected, I thought there would be some DRM/Steam issues).

@Blisto91
Copy link
Contributor

Blisto91 commented Mar 31, 2023

Thanks for the PR.
I see the game also have a bunch of editor exe's. Do you know if any of these need the same built in config to function properly?

@w-flo
Copy link
Contributor Author

w-flo commented Mar 31, 2023

That's a great question!

I've never used these editors and don't really know how to use them (they seem complicated), but giving them a very superficial test:

  • ZusiFtdEditor.64.exe: This one appears broken with dxvk, with and without "noExplicitFrontBuffer". Instead of the cab view image, there is just a gray area with the cab view flickering for ~1 frame when clicking the gray area. This is not an issue when using wine d3d9 apparently.
  • Zusi3DEditor.64.exe: I haven't noticed any obvious issues when not using the config.
  • ZusiFzgEditor.64.exe, ZusiDateiverwaltung.exe: It seems like these don't use D3D
  • ZusiGleisplanEditor.exe: Not sure how to launch this one (it attempts to launch using my wine-mono installation, even though it should probably use MS dotnet from the game's Proton wineprefix instead)

@Blisto91
Copy link
Contributor

Blisto91 commented Mar 31, 2023

Thanks for the extra testing. I have asked besentv if he has any input on the last exe.

Edit: Would you be able to make a issue for the ZusiFtdEditor.64.exe problem?

@w-flo
Copy link
Contributor Author

w-flo commented Apr 3, 2023

Edit: Would you be able to make a issue for the ZusiFtdEditor.64.exe problem?

Sure, I'll try to find out what is going on, and then open an issue (if I can't find an existing issue for this problem).

Thanks for the review :-)

@w-flo
Copy link
Contributor Author

w-flo commented Apr 4, 2023

Not sure where to put this, about the ZusiFtdEditor.64.exe issue: I suspect it may not be a dxvk bug after all. There are two layers in that editor preview feature: The rendered cab view image itself (D3D9) as it would appear in the game, and an additional layer on top of it that draws rectangles around selected elements in the cab view. When using dxvk, only the "rectangle layer" is visible with gray areas inside and inbetween rectangles, instead of the cab view image. When not using dxvk, only the cab view layer is visible and rectangles are missing. So maybe dxvk is actually less buggy here, and wine just needs to learn to make those pixels in the "rectangle layer" that are not actually part of a rectangles transparent instead of opaque gray – or something along those lines. So I'd consider it "not a dxvk bug" for now.

@K0bin K0bin merged commit 01dc9dd into doitsujin:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zusi 3 (1040730) has broken cab images
3 participants